fix: Failure to import LD project other than default
#2979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix the bug - Better wording
khvn26
requested review from
a team and
novakzaballa
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
front-end
|
Uffizzi Preview |
| createLaunchDarklyProjectImport({ | ||
| body: { project_key: 'default', token: LDKey }, | ||
| body: { project_key: key, token: LDKey }, |
There was a problem hiding this comment.
What's the difference between a project key and a project id 🤔 ?
There was a problem hiding this comment.
project_id is Flagsmith's project ID. project_key is LD's project key.
There was a problem hiding this comment.
Naming could be better here!
There was a problem hiding this comment.
(but that's unrelated to this PR I guess)
There was a problem hiding this comment.
I second that, but wanted a minimal diff for this one.
zachaysan
approved these changes
Nov 15, 2023
matthewelwell
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2978.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingChanges
This uses the project key retrieved from LD api rather than the hardcoded
defaultwhen creating an import request.How did you test this code?
npm run devlocally.