Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move and merge features tests into proper location #3002

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

zachaysan
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Moved features tests into the unit location. Some of these were just renaming the file, others were a full merge with an existing test file at the destination directory.

How did you test this code?

I ran the test files after the merge individually to ensure that conftest didn't clobber fixtures and to make sure that the merged code ran ok.

Copy link

vercel bot commented Nov 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 3:33pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 3:33pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 3:33pm

Copy link
Contributor

github-actions bot commented Nov 20, 2023

Uffizzi Preview deployment-41106 was deleted.

Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaysan zachaysan added this pull request to the merge queue Nov 20, 2023
Merged via the queue into main with commit 5f3482c Nov 20, 2023
@zachaysan zachaysan deleted the fix/move_feature_tests branch November 20, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants