feat: Import / export of features across environments and orgs #3026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zachaysan
commented
Nov 23, 2023
zachaysan
commented
Nov 23, 2023
zachaysan
commented
Nov 23, 2023
zachaysan
commented
Nov 23, 2023
zachaysan
commented
Nov 23, 2023
…ures_from_environments
|
Uffizzi Preview |
6 tasks
matthewelwell
approved these changes
Dec 7, 2023
| @permission_classes([FeatureImportPermissions]) | ||
| def feature_import(request: Request, environment_id: int) -> Response: | ||
| upload_serializer = FeatureImportUploadSerializer(data=request.data) | ||
| upload_serializer.is_valid(raise_exception=True) |
There was a problem hiding this comment.
@zachaysan I moved this check here to follow standard DRF patterns.
There was a problem hiding this comment.
Ah. Okay yeah that makes more sense.
| def feature_import(request: Request, environment_id: int) -> Response: | ||
| upload_serializer = FeatureImportUploadSerializer(data=request.data) | ||
| upload_serializer.is_valid(raise_exception=True) | ||
| _feature_import = upload_serializer.save(environment_id=environment_id) |
There was a problem hiding this comment.
I changed the name of this variable to stop my IDE complaining about it shadowing the name from the outer scope.
zachaysan
deleted the
feat/import_export_of_features_from_environments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingChanges
This PR allows someone using Flagsmith to export the information around their feature flags from a given environment in order to import them into another environment even at a different organisation or instance of flagsmith. Changes include:
environment_idand a list oftag_idsas part of a post body and kicks off a job to generate the export."Production | 2023-11-23 15:36 UTC".id.SKIPwhich skips any existing features that are named the same thing. The second is calledOVERWRITEwhich discards an existing feature and related objects before creating a new one to load with.How did you test this code?
Many individual tests for the views and the tasks. To test import and export tasks I elected to test them together to verify the process worked from download to upload. I also manually tested the file download endpoint to make sure the header was correctly set to initiate a download.
I was unable to test the JavaScript friendly file upload API, so although I tried my best to follow guides, the implementer of the frontend (Novak) may want to have me on a video call when he's wiring that part up.