feat: Rebuild chargebee caches #3028
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3028 +/- ##
=======================================
Coverage 95.73% 95.74%
=======================================
Files 1044 1045 +1
Lines 30866 30889 +23
=======================================
+ Hits 29551 29574 +23
Misses 1315 1315 ☔ View full report in Codecov by Sentry. |
| ) | ||
| # Then | ||
| assert response.status_code == 200 | ||
| task.assert_called_once() |
There was a problem hiding this comment.
I'd rather be more specific here - wouldn't it be simpler (and more specific) to just mock the task function in the webhook_handlers module and then call like mocked_task.delay.assert_called_once_with() ?
I think the current implementation also relies on settings.TASK_RUN_METHOD == "SYNCHRONOUSLY" whereas the above approach wouldn't?
There was a problem hiding this comment.
Sure I can switch it to that. I like to call tasks but if you don't think there is value here I can mock the task.
There was a problem hiding this comment.
Ok this has been updated :)
| ) | ||
| # Then | ||
| assert response.status_code == 200 | ||
| task.delay.assert_called_once() |
There was a problem hiding this comment.
I think I'd prefer to see this as task.delay.assert_called_once_with() to prove that we're calling it with no arguments, but it's not super important.
There was a problem hiding this comment.
Sure that's no problem :)
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingChanges
Added another chargebee webhook handler function to filter events that may lead to us needing to update the chargebee cache.
How did you test this code?
Played around with the code by hand to make sure I understood the chargebee API plus some work on their test interface UI to get the webhook information then a single test based off of typical event. It's not complicated code so I'm not worried.