fix: remove pagination from group summaries #3090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zachaysan
approved these changes
Dec 4, 2023
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3090 +/- ##
=======================================
Coverage 95.88% 95.88%
=======================================
Files 1035 1035
Lines 30773 30777 +4
=======================================
+ Hits 29508 29512 +4
Misses 1265 1265 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Since the FE needs to be able to grab the list of groups for an organisation to e.g. populate the group owners on a feature, and the summaries endpoint only returns 2 attributes for each group, we can safely remove the pagination from this endpoint.
Note that this endpoint has not yet been released to production but this needs to be merged before the next release of the API to ensure that we're not creating breaking changes to the API.
How did you test this code?
Updated the unit test.