Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new url for role users #3120

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

novakzaballa
Copy link
Contributor

@novakzaballa novakzaballa commented Dec 8, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Add new URL for role users:
    GET: /organisations/{organisation_pk}/users/{users_pk}/roles/
    DELETE: /organisations/{organisation_pk}/users/{users_pk}/roles/{role_pk}

How did you test this code?

The unit tests included in the RBAC PR: https://github.com/Flagsmith/flagsmith-rbac/pull/16

Copy link

vercel bot commented Dec 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 5:34pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 5:34pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 5:34pm

@github-actions github-actions bot added the api Issue related to the REST API label Dec 8, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Uffizzi Preview deployment-42432 was deleted.

@novakzaballa novakzaballa linked an issue Dec 8, 2023 that may be closed by this pull request
@novakzaballa novakzaballa requested review from a team and gagantrivedi and removed request for a team December 8, 2023 17:31
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (601d499) 95.91% compared to head (596bb90) 95.90%.
Report is 3 commits behind head on main.

Files Patch % Lines
api/organisations/urls.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3120      +/-   ##
==========================================
- Coverage   95.91%   95.90%   -0.01%     
==========================================
  Files        1048     1048              
  Lines       31382    31384       +2     
==========================================
  Hits        30100    30100              
- Misses       1282     1284       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@novakzaballa novakzaballa added this pull request to the merge queue Dec 8, 2023
Merged via the queue into main with commit 0604ec1 Dec 8, 2023
17 checks passed
@novakzaballa novakzaballa deleted the feat/add-new-url-for-role-users branch December 8, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading role permissions generates 500 errors
3 participants