feat: Set feature export response on initial API request #3126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3126 +/- ##
==========================================
- Coverage 95.90% 95.89% -0.01%
==========================================
Files 1048 1049 +1
Lines 31384 31409 +25
==========================================
+ Hits 30100 30121 +21
- Misses 1284 1288 +4 ☔ View full report in Codecov by Sentry. |
zachaysan
requested review from
a team and
novakzaballa
and removed request for
a team
novakzaballa
approved these changes
Dec 8, 2023
zachaysan
deleted the
feat/set_feature_export_response_on_init_request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Instead of taking the initial API request that would allow a new
FeatureExportto create in the background, now an empty instance is created and passed off to the task responsible for generating the document and indicating success afterwards.How did you test this code?
A number of existing tests provided coverage and were updated as the endpoint and task signature was changed.