fix: hide additional actions on identity overrides tab in Edge #3135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
a team and
novakzaballa
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
front-end
|
Uffizzi Preview |
kyle-ssg
approved these changes
Dec 11, 2023
matthewelwell
deleted the
fix/extra-actions-on-identity-overrides-tab
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR hides the additional actions on the Identity Overrides tab in the Create/Edit feature modal. Until this can be looked into in more detail, we should hide these actions and treat this data as read only for now.
I did try to get the toggle working, but it was not possible (at least not easily with my JS skills) since the data which powers the endpoint does not update quickly enough to return the newly updated value when the re-rendering happens.
How did you test this code?
Ran the FE locally against the staging API and confirmed that the actions are not visible for an Edge project.
To test it, add yourself to organisation 40, either via the django admin, or using this invite link and view the
testfeature in the Production environment.