Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: re-add identity overrides for core projects #3139

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix: re-add identity overrides for core projects #3139

merged 1 commit into from
Dec 11, 2023

Conversation

matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Dec 11, 2023 •
edited
Loading

Changes

Re-add identity overrides tab for core projects that was broken by this PR.

How did you test this code?

Ran FE locally and verified that all combinations behave as expected.

Test Scenarios:

  • Core project should show identity overrides regardless of the status of the show_edge_identity_overrides flag
  • Edge project should not show identity overrides regardless of the value of "show_edge_identity_overrides_for_feature" if the show_edge_identity_overrides flag is disabled
  • Edge project should not show identity overrides regardless of the state of the flag show_edge_identity_overrides if the value of "show_edge_identity_overrides_for_feature" is not "COMPLETE"
  • Edge project should show identity overrides if the value of "show_edge_identity_overrides_for_feature" is not "COMPLETE" and the flag show_edge_identity_overrides is enabled

@vercel Vercel
Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 11, 2023 7:11pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Dec 11, 2023 7:11pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Dec 11, 2023 7:11pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Dec 11, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2023 •
edited
Loading

Uffizzi Ephemeral Environment deployment-42582

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/3139

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@matthewelwell matthewelwell added this pull request to the merge queue Dec 11, 2023
Merged via the queue into main with commit 8a5c20f Dec 11, 2023
16 checks passed
@matthewelwell matthewelwell deleted the fix/re-add-identity-overrides-for-core branch December 11, 2023 19:23
@dabeeeenster dabeeeenster mentioned this pull request Dec 11, 2023
Merged
@dabeeeenster dabeeeenster mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabeeeenster dabeeeenster dabeeeenster approved these changes

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewelwell @dabeeeenster