Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dockerfile): Use correct secret ID for pgp_key #3141

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Dec 12, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Use correct secret ID in Dockerfile

How did you test this code?

By running the image build here: https://github.com/Flagsmith/flagsmith/actions/runs/7176928514 locally to make sure gpg is installed

Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 12, 2023 6:00am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Dec 12, 2023 6:00am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Dec 12, 2023 6:00am

@github-actions github-actions bot added the api Issue related to the REST API label Dec 12, 2023
@gagantrivedi gagantrivedi changed the title Fix pgp secret fix(Dockerfile): Use correct secret ID for pgp_key Dec 12, 2023
Copy link
Contributor

github-actions bot commented Dec 12, 2023

Uffizzi Preview deployment-42607 was deleted.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (068253e) 96.08% compared to head (2c8b8b1) 96.08%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3141      +/-   ##
==========================================
- Coverage   96.08%   96.08%   -0.01%     
==========================================
  Files        1054     1054              
  Lines       31702    31699       -3     
==========================================
- Hits        30462    30459       -3     
  Misses       1240     1240              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi requested review from a team and khvn26 and removed request for a team December 12, 2023 07:01
@gagantrivedi gagantrivedi added this pull request to the merge queue Dec 12, 2023
Merged via the queue into main with commit 44ee410 Dec 12, 2023
18 checks passed
@gagantrivedi gagantrivedi deleted the fix-pgp-secret-id branch December 12, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants