-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fine tune feature import export #3163
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3163 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 1058 1058
Lines 31918 31959 +41
=======================================
+ Hits 30677 30718 +41
Misses 1241 1241 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of minor comments but looks good on the whole.
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingChanges
As @kyle-ssg and I were going through the frontend integration a number of quality of life improvements came up:
created_at
descending, since the newest created feature export should be at the top of the list.tag_strategy
serializer field which defaults to the old behavior and I added the new feature to the test suite plus an additional one since the old behaviour had no test coverage.How did you test this code?
New tests and verified an existing one.