Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Count v2 identity overrides for feature state list view #3164

Merged
merged 6 commits into from
Dec 19, 2023
Merged

feat: Count v2 identity overrides for feature state list view #3164

merged 6 commits into from
Dec 19, 2023

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Dec 14, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Adds identity override retrieval from flagsmith_environments_v2 when preparing override counts.
  • Base class for DynamoDB yet again changed to accommodate for all usage patterns.
  • Naming improvements.

How did you test this code?

Modified and added unit tests.

@khvn26 khvn26 requested review from a team and matthewelwell and removed request for a team December 14, 2023 02:08
@vercel Vercel
Copy link

vercel bot commented Dec 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 2:17pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 2:17pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 2:17pm

@github-actions github-actions bot added the api Issue related to the REST API label Dec 14, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 14, 2023 •
edited
Loading

Uffizzi Preview deployment-42802 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023 •
edited
Loading

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (fc3bce0) 96.11% compared to head (306b733) 96.11%.
Report is 2 commits behind head on main.

Files Patch % Lines
...it/features/test_unit_features_features_service.py 93.10% 4 Missing ⚠️
api/environments/dynamodb/utils.py 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #3164    +/-   ##
========================================
  Coverage   96.11%   96.11%            
========================================
  Files        1059     1059            
  Lines       32037    32149   +112     
========================================
+ Hits        30792    30900   +108     
- Misses       1245     1249     +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matthewelwell
matthewelwell reviewed Dec 14, 2023
View reviewed changes
api/conftest.py Outdated Show resolved Hide resolved
api/environments/dynamodb/dynamodb_wrapper.py Outdated Show resolved Hide resolved
api/environments/dynamodb/dynamodb_wrapper.py Outdated Show resolved Hide resolved
api/features/features_service.py Show resolved Hide resolved
api/features/features_service.py Show resolved Hide resolved
api/features/features_service.py Outdated Show resolved Hide resolved
api/tests/unit/features/test_unit_features_features_service.py Show resolved Hide resolved
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Dec 14, 2023
@khvn26 khvn26 requested a review from matthewelwell December 14, 2023 10:27
@khvn26 khvn26 force-pushed the feat/count-badge-for-v2-identity-overrides branch from b918d67 to 1aa00c9 Compare December 14, 2023 10:44
matthewelwell
matthewelwell requested changes Dec 18, 2023
View reviewed changes
api/environments/dynamodb/dynamodb_wrapper.py Outdated Show resolved Hide resolved
frontend/web/components/FeatureRow.js Outdated Show resolved Hide resolved
api/features/features_service.py Outdated Show resolved Hide resolved
api/features/features_service.py Outdated Show resolved Hide resolved
@khvn26 khvn26 force-pushed the feat/count-badge-for-v2-identity-overrides branch from 1aa00c9 to a52efad Compare December 18, 2023 13:40
@github-actions github-actions bot removed the front-end Issue related to the React Front End Dashboard label Dec 18, 2023
@khvn26 khvn26 mentioned this pull request Dec 18, 2023
Merged
5 tasks
@khvn26 khvn26 force-pushed the feat/count-badge-for-v2-identity-overrides branch from de5876c to 306b733 Compare December 18, 2023 14:13
@khvn26 khvn26 requested a review from matthewelwell December 18, 2023 15:33
@khvn26 khvn26 added this pull request to the merge queue Dec 19, 2023
Merged via the queue into main with commit 65be52b Dec 19, 2023
18 checks passed
@khvn26 khvn26 deleted the feat/count-badge-for-v2-identity-overrides branch December 19, 2023 10:24
@dabeeeenster dabeeeenster mentioned this pull request Dec 18, 2023
Merged
@dabeeeenster dabeeeenster mentioned this pull request Apr 18, 2024
Closed
@matthewelwell matthewelwell mentioned this pull request Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
api Issue related to the REST API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khvn26 @codecov-commenter @matthewelwell