Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sse/tracking): Use INFLUXDB_BUCKET for storing data #3197

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Dec 20, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Use INFLUXDB_BUCKET for storing sse usage data instead of SSE_INFLUXDB_BUCKET

How did you test this code?

Update unit test

Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2023 9:21am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2023 9:21am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2023 9:21am

Copy link
Contributor

github-actions bot commented Dec 20, 2023

Uffizzi Preview deployment-43263 was deleted.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6898253) 96.02% compared to head (236826a) 96.02%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3197      +/-   ##
==========================================
- Coverage   96.02%   96.02%   -0.01%     
==========================================
  Files        1062     1062              
  Lines       32220    32219       -1     
==========================================
- Hits        30938    30937       -1     
  Misses       1282     1282              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi added this pull request to the merge queue Dec 20, 2023
Merged via the queue into main with commit fbd14fe Dec 20, 2023
18 checks passed
@gagantrivedi gagantrivedi deleted the fix/sse-tracking-bucket branch December 20, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants