Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(infra/staging): Add INFLUXDB_BUCKET to task def #3199

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Dec 20, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Remove runtime check to configure influx in staging correctly(because of SSE tracking)
Add INFLUXDB_BUCKET environment variable to staging task processor task definition

How did you test this code?

Covered by unit tests

Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2024 2:35am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2024 2:35am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2024 2:35am

Copy link
Contributor

github-actions bot commented Dec 20, 2023

Uffizzi Preview deployment-43270 was deleted.

api/app/settings/common.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a14eb23) 96.02% compared to head (dd987c4) 17.55%.
Report is 31 commits behind head on main.

Files Patch % Lines
api/app/settings/common.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3199       +/-   ##
===========================================
- Coverage   96.02%   17.55%   -78.48%     
===========================================
  Files        1062      983       -79     
  Lines       32219    28398     -3821     
===========================================
- Hits        30937     4984    -25953     
- Misses       1282    23414    +22132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi added this pull request to the merge queue Jan 3, 2024
Merged via the queue into main with commit 445dc2b Jan 3, 2024
21 checks passed
@gagantrivedi gagantrivedi deleted the fix/influx-add-bucket branch January 3, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants