Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reset password error handling #3271

Merged
merged 1 commit into from
Jan 16, 2024
Merged

fix: Reset password error handling #3271

merged 1 commit into from
Jan 16, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Reset password page now shows field errors
  • Field errors that are an array will now show on separate lines
image

How did you test this code?

  • Attempted reset password with bad data

@kyle-ssg kyle-ssg requested a review from novakzaballa January 11, 2024 10:48
@vercel Vercel
Copy link

vercel bot commented Jan 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 10:54am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 10:54am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 10:54am

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jan 11, 2024
@kyle-ssg kyle-ssg linked an issue Jan 11, 2024 that may be closed by this pull request
show new password validations in the frontend #3221
Closed
@kyle-ssg kyle-ssg changed the title Reset password error handling fix: Reset password error handling Jan 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 11, 2024 •
edited
Loading

Uffizzi Preview deployment-44175 was deleted.

novakzaballa
novakzaballa reviewed Jan 11, 2024
View reviewed changes
Copy link
Contributor

@novakzaballa novakzaballa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't replicate it in staging, maybe I'm doing something wrong?
Screen Shot 2024-01-11 at 15 48 11

@kyle-ssg
Copy link
Member Author

kyle-ssg commented Jan 15, 2024 •
edited
Loading

@novakzaballa I think you're probably clicking the forgot password email link which is staging rather than the PR branch, if you want to test it, take your emailed reset password link and replace staging.flagsmith.com with https://flagsmith-frontend-staging-git-fix-reset-passw-053898-flagsmith.vercel.app/

@kyle-ssg kyle-ssg enabled auto-merge January 15, 2024 09:39
@kyle-ssg kyle-ssg disabled auto-merge January 15, 2024 09:39
@novakzaballa novakzaballa self-requested a review January 15, 2024 13:18
novakzaballa
novakzaballa approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyle-ssg Approved

@kyle-ssg kyle-ssg added this pull request to the merge queue Jan 16, 2024
Merged via the queue into main with commit a54352f Jan 16, 2024
19 checks passed
@kyle-ssg kyle-ssg deleted the fix/reset-password-error branch January 16, 2024 09:27
@dabeeeenster dabeeeenster mentioned this pull request Jan 15, 2024
Merged
@dabeeeenster dabeeeenster mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novakzaballa novakzaballa novakzaballa approved these changes

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

show new password validations in the frontend
2 participants
@kyle-ssg @novakzaballa