Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Paging spacer logic #3275

Merged
merged 2 commits into from
Jan 12, 2024
Merged

fix: Paging spacer logic #3275

merged 2 commits into from
Jan 12, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

The paging spacer should show when the last and second last pages aren't visible, currently this shows when there's only 1 page.

Before:

image

After:

image

How did you test this code?

image image image image image

@kyle-ssg kyle-ssg requested a review from novakzaballa January 11, 2024 13:36
Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 1:45pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 1:45pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 1:45pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jan 11, 2024
Copy link
Contributor

github-actions bot commented Jan 11, 2024

Uffizzi Preview deployment-44187 was deleted.

@kyle-ssg kyle-ssg added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit 00ac34e Jan 12, 2024
19 checks passed
@kyle-ssg kyle-ssg deleted the fix/paging-spacer-logic branch January 12, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants