-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: project usage limits #3313
feat: project usage limits #3313
Conversation
@MatheusLasserre is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
Thanks for this! Could we add a link to the docs here: https://docs.flagsmith.com/system-administration/system-limits with the text:
|
@dabeeeenster done! |
…ded Project Type to Responses object; Added getProject to Requests
@kyle-ssg I've done almost all the changes you suggested, except the I need a bit of a help here. As far as i know, there is not a endpoint that I can pass an array of ApiKeys, and it returns me an array of Environments. And if I use the For now, I've kept the previous forEach logic. |
@MatheusLasserre Awesome! Ok gotcha, yep I see, so we have to fetch a collection of environments. In that case leave this however you can replace "getEnvironmentResType" with Environment I believe |
<Row> | ||
<InfoMessage> | ||
In order to ensure consistent performance, Flagsmith has some{' '} | ||
<a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to ensure consistent performance, Flagsmith has the following usage limits. <a ...>Check the Docs for more details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Yep, that's what I did. In the end, the only type created was for the Should i do anything else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now. @kyle-ssg can you do another review?
Looking way neater now, awesome stuff. Thank you so much! |
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
closes Surface Segment/Feature/Segment override limits #2980
How did you test this code?
I've run Flasgsmith Frontend locally with npm run dev, opened the Settings page and went to the new Usage tab.
Also checked console and network to see if any error occurred.
Other:
![image](https://private-user-images.githubusercontent.com/77826309/298949807-4542a42d-7833-495a-960b-57cec6378c5c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NTUzMDEsIm5iZiI6MTczODk1NTAwMSwicGF0aCI6Ii83NzgyNjMwOS8yOTg5NDk4MDctNDU0MmE0MmQtNzgzMy00OTVhLTk2MGItNTdjZWM2Mzc4YzVjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDE5MDMyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ4YTM4MDNiYmI2MzY0OWZiNTc4OThmMjM1OTA0ZjNiNDVkZGEwYmQ3MmQ4ZDdhZjZhNjMxZjJkYTkwZDIwNmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.jxYq4b5QJNKEQ87G6ZPBaEc7KToL_7z6h16XblNJd5E)
I've kept the design pretty simple. Let me know if you want it more elaborated. Any visual reference will be appreciated.