Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: segment paging #3332

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix: segment paging #3332

merged 1 commit into from
Jan 29, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Segment requests need to transform api responses so that it can track paging.

Before:
image

After:

image

How did you test this code?

  • Viewed paginated segments

@kyle-ssg kyle-ssg requested a review from dabeeeenster January 25, 2024 15:22
@vercel Vercel
Copy link

vercel bot commented Jan 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 25, 2024 3:25pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2024 3:25pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2024 3:25pm

@kyle-ssg kyle-ssg linked an issue Jan 25, 2024 that may be closed by this pull request
Paging for multiple list views showing NaN #3329
Closed
4 tasks
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jan 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 25, 2024 •
edited
Loading

Uffizzi Preview deployment-45129 was deleted.

@kyle-ssg kyle-ssg requested a review from novakzaballa January 26, 2024 17:49
novakzaballa
novakzaballa approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyle-ssg kyle-ssg added this pull request to the merge queue Jan 29, 2024
Merged via the queue into main with commit 8050aed Jan 29, 2024
19 checks passed
@kyle-ssg kyle-ssg deleted the fix/segment-paging branch January 29, 2024 15:07
@dabeeeenster dabeeeenster mentioned this pull request Jan 29, 2024
Merged
@dabeeeenster dabeeeenster mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novakzaballa novakzaballa novakzaballa approved these changes

@dabeeeenster dabeeeenster Awaiting requested review from dabeeeenster

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Paging for multiple list views showing NaN
2 participants
@kyle-ssg @novakzaballa