Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tweak sdk copy #3341

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix: tweak sdk copy #3341

merged 1 commit into from
Jan 29, 2024

Conversation

dabeeeenster
Copy link
Contributor

@dabeeeenster dabeeeenster commented Jan 29, 2024 •
edited
Loading

Old:
image

New:
image

@dabeeeenster dabeeeenster requested review from a team and khvn26 January 29, 2024 15:34
@vercel Vercel
Copy link

vercel bot commented Jan 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 3:39pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 3:39pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 3:39pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jan 29, 2024
@dabeeeenster dabeeeenster requested review from kyle-ssg and a team January 29, 2024 15:36
@dabeeeenster dabeeeenster added the improvement Improvement to the existing platform label Jan 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2024 •
edited
Loading

Uffizzi Preview deployment-45300 was deleted.

@matthewelwell matthewelwell added this pull request to the merge queue Jan 29, 2024
Merged via the queue into main with commit 13617c5 Jan 29, 2024
19 checks passed
@matthewelwell matthewelwell deleted the fix/tweak-sdk-copy branch January 29, 2024 17:04
@dabeeeenster dabeeeenster mentioned this pull request Jan 29, 2024
Merged
matthewelwell
matthewelwell reviewed Jan 29, 2024
View reviewed changes
frontend/web/components/AdminAPIKeys.js
items={apiKeys}
header={
<Row className='table-header'>
<Flex className='table-column px-3'>API Keys</Flex>
<Flex className='table-column px-3'>Terraform API Keys</Flex>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this change back to Terraform API keys? This was changed on purpose since we're soon going to support regular API keys (using roles etc.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's clearer right now. We would probably want to split out legacy keys in a separate table anyway?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by 'legacy keys' ??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I mean I'm not sure what we are doing with "Terraform keys" are we going to deprecate them or call them something different?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're just going to exist in the same 'API keys' section

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the exact same entity under the hood.

@dabeeeenster dabeeeenster mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell left review comments

@khvn26 khvn26 khvn26 approved these changes

@kyle-ssg kyle-ssg Awaiting requested review from kyle-ssg

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard improvement Improvement to the existing platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dabeeeenster @khvn26 @matthewelwell