fix(redis_cache): extend DefaultClient class to add support for RedisClusterException #3392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5 tasks
|
Uffizzi Preview |
gagantrivedi
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3392 +/- ##
===========================================
- Coverage 95.93% 18.38% -77.56%
===========================================
Files 1077 997 -80
Lines 32944 28832 -4112
===========================================
- Hits 31606 5300 -26306
- Misses 1338 23532 +22194 ☔ View full report in Codecov by Sentry. |
khvn26
reviewed
Feb 7, 2024
api/core/redis_cluster.py
Outdated
Comment on lines
55
to
62
| def _safe_operation(self, func): | ||
| def wrapper(*args, **kwargs): | ||
| try: | ||
| return func(*args, **kwargs) | ||
| except RedisClusterException as e: | ||
| raise ConnectionInterrupted(connection=None) from e | ||
|
|
||
| return wrapper |
There was a problem hiding this comment.
Nit: probably should be a staticmethod.
khvn26
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
RedisClusterExceptiontoConnectionInterrupted(handled/defined by django_redis)connection_factoryas part of init to avoid setting it explicitlyHow did you test this code?