fix: Limit segment rules and conditions #3397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Co-authored-by: Matthew Elwell <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3397 +/- ##
==========================================
+ Coverage 95.91% 95.93% +0.01%
==========================================
Files 1085 1087 +2
Lines 33677 33805 +128
==========================================
+ Hits 32302 32430 +128
Misses 1375 1375 ☔ View full report in Codecov by Sentry. |
The mishandled errors have been fixed in this PR: #3413 |
Ok no problem. Added this locally. |
matthewelwell
approved these changes
Feb 14, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingI have added information todocs/if required so people know about the feature!Changes
Introduce a limit via settings constant to limit the number of conditions a segment can undergo before rejection.
How did you test this code?
Two long unit tests one for the update the other for the create. Existing tests can handle the cases where we want to see segments created in response to API input.