Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fs-delete/webhook): use fs instance instead of historical #3475

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Feb 28, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Use feature state instance for delete feature webhook instead of historical instance (because historical record does not exist for feature states created before we introduced history and for some reason they also did not exists for the feature here: https://flagsmith.sentry.io/issues/4929553990/?project=5544478&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=24h&stream_index=19)

How did you test this code?

Add new unit test

Copy link

sentry-io bot commented Feb 28, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: api/features/tasks.py

Function Unhandled Issue
trigger_feature_state_change_webhooks AttributeError: 'NoneType' object has no attribute 'instance' /api/v1/projects/{project_pk}/f...
Event Count: 8

Did you find this useful? React with a 👍 or 👎

Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Feb 28, 2024 7:19am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Feb 28, 2024 7:19am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Feb 28, 2024 7:19am

@github-actions github-actions bot added the api Issue related to the REST API label Feb 28, 2024
@gagantrivedi gagantrivedi requested review from a team and matthewelwell and removed request for a team February 28, 2024 07:20
Copy link
Contributor

github-actions bot commented Feb 28, 2024

Uffizzi Preview deployment-47402 was deleted.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.91%. Comparing base (76def7c) to head (8c19bca).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3475   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files        1092     1092           
  Lines       33991    34006   +15     
=======================================
+ Hits        32601    32616   +15     
  Misses       1390     1390           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi added this pull request to the merge queue Mar 1, 2024
Merged via the queue into main with commit 90e10cf Mar 1, 2024
23 checks passed
@gagantrivedi gagantrivedi deleted the fix/delete-webhook branch March 1, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants