fix: N+1 on segment overrides for environment-document endpoint #3512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matthewelwell
commented
Feb 29, 2024
| # and the relevant URL to get an environment document | ||
| url = reverse("api-v1:environment-document") | ||
|
|
||
| # When | ||
| with django_assert_num_queries(11): | ||
| with django_assert_num_queries(13): |
There was a problem hiding this comment.
This number increased to 23 before I added the select related. I think the additional 2 queries are legitimate for retrieving the MV data and the segment overrides.
|
Uffizzi Preview |
khvn26
approved these changes
Feb 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3512 +/- ##
=======================================
Coverage 95.85% 95.85%
=======================================
Files 1097 1097
Lines 34117 34125 +8
=======================================
+ Hits 32704 32712 +8
Misses 1413 1413 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Fixes an N+1 issue on environment-document endpoint caused by retrieving the environment for each segment override.
How did you test this code?
Updated the test for the environment-document endpoint to include segment overrides. Confirmed that the number of queries increased linearly with the number of segment overrides, then reduced once the new select related argument was added.