Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dasherize conversion event types path #3516

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

zachaysan
Copy link
Contributor

@zachaysan zachaysan commented Mar 1, 2024

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes https://github.com/Flagsmith/flagsmith-split-testing/issues/7

I accidentally used underscores when I first wrote this code. This is a simple fix.

How did you test this code?

N/A

@github-actions github-actions bot added the api Issue related to the REST API label Mar 1, 2024
Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs 🛑 Canceled (Inspect) Mar 1, 2024 4:30pm
flagsmith-frontend-preview 🛑 Canceled (Inspect) Mar 1, 2024 4:30pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 4:30pm

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Uffizzi Preview deployment-47628 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.86%. Comparing base (90e10cf) to head (b7ed4a5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3516   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files        1097     1097           
  Lines       34140    34140           
=======================================
  Hits        32727    32727           
  Misses       1413     1413           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachaysan zachaysan requested a review from novakzaballa March 1, 2024 15:16
Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just needed to re-run a flaky test. Please ensure all tests have passed before requesting a review.

@zachaysan zachaysan added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit 994eb55 Mar 4, 2024
23 checks passed
@zachaysan zachaysan deleted the fix/conversion_event_types_path branch March 4, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants