fix(audit): create audit log for deleted conditions in a segment #3577
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
This PR solves an issue noticed in customer testing which showed that audit log records are not properly created when a condition is removed from a segment. The issue was caused by the following exception in the task processor:
To resolve it, I have simply added soft delete to both the SegmentRule and Condition models.
How did you test this code?
This is really hard to test in unit test because it's essentially a race condition. It's very easy to test when using the Task Processor, however, so I have run the application locally with the task processor and verified the issue exists before then resolving it with the code here and retesting it locally to confirm that the issue no longer exists.