-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Filter features by owners and group owners #3579
feat: Filter features by owners and group owners #3579
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: api/features/views.py
Did you find this useful? React with a 👍 or 👎 |
Uffizzi Preview |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3579 +/- ##
==========================================
- Coverage 95.86% 95.85% -0.01%
==========================================
Files 1097 1097
Lines 34141 34204 +63
==========================================
+ Hits 32728 32787 +59
- Misses 1413 1417 +4 ☔ View full report in Codecov by Sentry. |
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
Added the ability to filter the features list by both group owners and owners. This allows for the intermixing of the two with the inclusion of either, so even though the query params filter separately they work together to union the results.
How did you test this code?
Three similar unit tests to check for inclusion / non-inclusion of the results.