fix(change-requests): prevent incorrect scheduled changes warning #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
front-end
|
Uffizzi Preview |
matthewelwell
commented
Mar 11, 2024
| @@ -19,10 +19,11 @@ const ExistingChangeRequestAlert: FC<ExistingChangeRequestAlertType> = ({ | |||
| environmentId, | |||
| feature_id: featureId, | |||
| }) | |||
| const date = useRef(moment().toISOString()) | |||
There was a problem hiding this comment.
Note that it was necessary (thanks to an assist from @kyle-ssg) to move this out to useRef to avoid an infinite recursion caused by the date being calculated on each re-render.
kyle-ssg
approved these changes
Mar 13, 2024
matthewelwell
deleted the
fix/scheduled-cr-warning-shows-after-committing-regular-cr
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
The FE shows the following warning based on the logic changed as part of this PR. I can't see any reason why it should use the start of the current hour instead of the current time so I have removed the
startOf('hour')clause.How did you test this code?
Tested using the vercel previews.