Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adjust permissions logic for view / manage groups #3679

Merged
merged 8 commits into from
Apr 8, 2024
Merged

fix: Adjust permissions logic for view / manage groups #3679

merged 8 commits into from
Apr 8, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Mar 26, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Removes /projects in place of /organisation-settings (which has the projects tab)
  • Allows user to see the groups tab if they are admin of any groups

Note : This will need to be considered when refactoring groups to rtk

How did you test this code?

  • Create a new group
  • Make a standard org user without any permissions a group admin
  • Login as user, manage groups

@vercel Vercel
Copy link

vercel bot commented Mar 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 11:28am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 11:28am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 11:28am

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Mar 26, 2024
@kyle-ssg
Merge branch 'main' into chore/show-groups-to-group-admin
8722efd 
# Conflicts:
#	frontend/web/components/pages/OrganisationSettingsPage.js
@kyle-ssg kyle-ssg marked this pull request as draft March 26, 2024 17:52
@kyle-ssg kyle-ssg changed the title Adjust permissions logic for view / manage groups fix: Adjust permissions logic for view / manage groups Mar 26, 2024
@kyle-ssg kyle-ssg requested review from novakzaballa and khvn26 March 26, 2024 17:56
@kyle-ssg kyle-ssg linked an issue Mar 26, 2024 that may be closed by this pull request
Group admins can't access Groups tab in organisation settings #3678
Closed
4 tasks
@kyle-ssg kyle-ssg marked this pull request as ready for review March 27, 2024 11:02
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 27, 2024 •
edited
Loading

Uffizzi Preview deployment-49008 was deleted.

@kyle-ssg
Merge branch 'main' into chore/show-groups-to-group-admin
4ed102c 
# Conflicts:
#	frontend/web/components/UserGroupList.tsx
@kyle-ssg kyle-ssg added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit 5ba3083 Apr 8, 2024
21 checks passed
@kyle-ssg kyle-ssg deleted the chore/show-groups-to-group-admin branch April 8, 2024 12:02
@dabeeeenster dabeeeenster mentioned this pull request Apr 4, 2024
Merged
@dabeeeenster dabeeeenster mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novakzaballa novakzaballa novakzaballa approved these changes

@khvn26 khvn26 Awaiting requested review from khvn26

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Group admins can't access Groups tab in organisation settings
2 participants
@kyle-ssg @novakzaballa