Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert CharFields to TextFields for FeatureImport / FeatureExport models #3720

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

matthewelwell
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

To support Oracle and MySQL (in our enterprise edition), we need to convert the CharFields here to TextFields, since the underlying column types in these database don't support the size we need.

How did you test this code?

Ran the migration and confirmed that no data was lost.

@matthewelwell matthewelwell requested a review from zachaysan April 4, 2024 17:13
Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 5:30pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 5:30pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 5:30pm

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Uffizzi Preview deployment-49518 was deleted.

Copy link
Contributor

@zachaysan zachaysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although the constants could have been used for the migration.

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (d5f76ff) to head (a6e99f0).
Report is 666 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3720   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files        1101     1102    +1     
  Lines       34681    34686    +5     
=======================================
+ Hits        33256    33261    +5     
  Misses       1425     1425           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit 6bebcef Apr 4, 2024
23 checks passed
@matthewelwell matthewelwell deleted the fix/convert-import-export-data-to-text-field branch April 4, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants