-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: convert CharFields to TextFields for FeatureImport / FeatureExport models #3720
fix: convert CharFields to TextFields for FeatureImport / FeatureExport models #3720
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, although the constants could have been used for the migration.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3720 +/- ##
=======================================
Coverage 95.89% 95.89%
=======================================
Files 1101 1102 +1
Lines 34681 34686 +5
=======================================
+ Hits 33256 33261 +5
Misses 1425 1425 ☔ View full report in Codecov by Sentry. |
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
To support Oracle and MySQL (in our enterprise edition), we need to convert the CharFields here to TextFields, since the underlying column types in these database don't support the size we need.
How did you test this code?
Ran the migration and confirmed that no data was lost.