Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(task-processor): catch all exceptions #3737

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

matthewelwell
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Catch all exceptions when retrieving tasks from the database.

How did you test this code?

Updated existing unit test.

@matthewelwell matthewelwell requested a review from khvn26 April 9, 2024 10:39
Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 10:46am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 10:46am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 10:46am

@github-actions github-actions bot added the api Issue related to the REST API label Apr 9, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Uffizzi Preview deployment-49805 was deleted.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (cd1f79c) to head (8391bf6).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3737   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files        1102     1102           
  Lines       34707    34708    +1     
=======================================
+ Hits        33282    33283    +1     
  Misses       1425     1425           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Apr 9, 2024
Merged via the queue into main with commit 84ab486 Apr 9, 2024
23 checks passed
@matthewelwell matthewelwell deleted the fix/catch-all-exceptions branch April 9, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants