fix: tests using has_calls instead of assert_has_calls
#3775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
a team and
zachaysan
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matthewelwell
requested review from
a team and
novakzaballa
and removed request for
zachaysan and
a team
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3775 +/- ##
=======================================
Coverage 95.91% 95.91%
=======================================
Files 1102 1102
Lines 34782 34782
=======================================
Hits 33362 33362
Misses 1420 1420 ☔ View full report in Codecov by Sentry. |
gagantrivedi
approved these changes
Apr 16, 2024
This was referenced Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Update tests to correctly use
assert_has_callsinstead ofhas_calls(which does nothing).How did you test this code?
Ran the updated unit tests and confirmed they passed.