Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add GitHub app URL to env var #3847

Merged
merged 8 commits into from
Apr 29, 2024
Merged

fix: Add GitHub app URL to env var #3847

merged 8 commits into from
Apr 29, 2024

Conversation

novakzaballa
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Create the new environment variable GITHUB_APP_URL to install the Flagsmith GitHub App.

  • Correct the capitalization of an occurrence of the GitHub word

How did you test this code?

Please describe.

@vercel Vercel
Copy link

vercel bot commented Apr 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 11:10am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 11:10am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 11:10am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard docs Documentation updates labels Apr 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 25, 2024 •
edited
Loading

Uffizzi Ephemeral Environment deployment-50858

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/3847

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 25, 2024 •
edited
Loading

Uffizzi Preview deployment-50858 was deleted.

@novakzaballa novakzaballa requested a review from kyle-ssg April 25, 2024 17:05
@matthewelwell
Copy link
Contributor

@novakzaballa feels like there's too many failures in the E2E tests for them to just be flaky?

@matthewelwell
Copy link
Contributor

@novakzaballa feels like there's too many failures in the E2E tests for them to just be flaky?

Hmm... weirdly they all passed on re-running but there were 5 failures originally!

matthewelwell
matthewelwell requested changes Apr 26, 2024
View reviewed changes
frontend/api/index.js Outdated Show resolved Hide resolved
frontend/web/components/IntegrationList.js Outdated Show resolved Hide resolved
kyle-ssg and others added 2 commits April 26, 2024 11:56
@github-actions github-actions bot added the api Issue related to the REST API label Apr 26, 2024
@kyle-ssg kyle-ssg requested a review from matthewelwell April 26, 2024 11:03
@kyle-ssg
Merge branch 'main' into fix/add-github-app-url-to-env-var
fdaf379 
# Conflicts:
#	frontend/web/components/IntegrationList.js
novakzaballa
novakzaballa commented Apr 26, 2024
View reviewed changes
Copy link
Contributor Author

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewelwell matthewelwell added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit 210dbf7 Apr 29, 2024
23 checks passed
@matthewelwell matthewelwell deleted the fix/add-github-app-url-to-env-var branch April 29, 2024 10:02
@dabeeeenster dabeeeenster mentioned this pull request Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyle-ssg kyle-ssg kyle-ssg approved these changes

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
api Issue related to the REST API docs Documentation updates front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@novakzaballa @matthewelwell @kyle-ssg