-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sentry-FLAGSMITH-API-4BN): update permission method #3851
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
cf1138d
to
23b6bde
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3851 +/- ##
==========================================
- Coverage 95.87% 95.87% -0.01%
==========================================
Files 1129 1129
Lines 35788 35787 -1
==========================================
- Hits 34310 34309 -1
Misses 1478 1478 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, but consider using the new fixture that I've mentioned in this PR since I think the plan will be to replace all occurrences with that fixture where possible.
23b6bde
to
f8179e0
Compare
Update get_permitted_environments on APIKeyUser to add support for prefetch_metadata
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
Update get_permitted_environments on APIKeyUser to add support for prefetch_metadata
Fixes: FLAGSMITH-API-4BN
How did you test this code?
Adds/updates unit tests