feat: Implement GitHub Webhook #3906
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3906 +/- ##
=======================================
Coverage 95.92% 95.93%
=======================================
Files 1134 1135 +1
Lines 35956 36028 +72
=======================================
+ Hits 34492 34564 +72
Misses 1464 1464 ☔ View full report in Codecov by Sentry. |
| @@ -245,6 +245,10 @@ | |||
| "name": "SSE_AUTHENTICATION_TOKEN", | |||
| "valueFrom": "arn:aws:secretsmanager:eu-west-2:084060095745:secret:ECS-API-LxUiIQ:SSE_AUTHENTICATION_TOKEN::" | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Have we added these secrete?
There was a problem hiding this comment.
Not yet, I don't have the credentials or authorization to do it. Could you?
There was a problem hiding this comment.
Have we added it to staging?
There was a problem hiding this comment.
I added instructions in the description on how to update the GitHub App once we have a secret defined and set.
There was a problem hiding this comment.
But we can't merge it without it, right?
There was a problem hiding this comment.
For another env var added @matthewelwell asked me to do first the PR declaring the env var in the infrastructure folder. And he set the value after that, however, I would say that he has the last word.
There was a problem hiding this comment.
Yeah, that makes sense, but we still can't merge it before the secrets are added because the deployment will fail
There was a problem hiding this comment.
@matthewelwell have set the env var secret.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Implement GitHub Webhook to receive events from GitHub App.
Initially we only handle the Integration Delete action. We delete the configuration and any related object in the DB when an installation is removed from GitHub.
Also, the env var
GITHUB_WEBHOOK_SECRETwas added to ECS task definition web secrets. This env var is not used by the tasks executed by the task processor. It is only used by the GitHub webhook.Once we generate the
GITHUB_WEBHOOK_SECRETwe need to update our GitHub App to use it as shown herehttps://github.com/organizations/Flagsmith/settings/apps/flagsmith
How did you test this code?
Unit tests added.