Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add global domain auth methods #3949

Merged
merged 1 commit into from
May 15, 2024

Conversation

zachaysan
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Adds the ability to set settings that will control the ability to globally block auth methods for the Flagsmith auth controller code.

How did you test this code?

N/A - testing will be done in the auth controller code.

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 6:58pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 6:58pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 6:58pm

Copy link
Contributor

github-actions bot commented May 14, 2024

Uffizzi Preview deployment-51715 was deleted.

@khvn26 khvn26 self-requested a review May 14, 2024 19:05
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.99%. Comparing base (97df705) to head (7669371).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3949   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files        1135     1135           
  Lines       36204    36205    +1     
=======================================
+ Hits        34754    34755    +1     
  Misses       1450     1450           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachaysan zachaysan added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 796564a May 15, 2024
24 checks passed
@zachaysan zachaysan deleted the feat/add_global_domain_auth_methods branch May 15, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants