fix: segment overrides stale feature state value while creating GitHub comment #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3961 +/- ##
=======================================
Coverage 96.01% 96.02%
=======================================
Files 1138 1138
Lines 36443 36460 +17
=======================================
+ Hits 34992 35009 +17
Misses 1451 1451 ☔ View full report in Codecov by Sentry. |
zachaysan
approved these changes
May 15, 2024
Comment on lines
+103
to
+106
| if ( | ||
| fs.get("segment_name") is not None | ||
| and fs["segment_name"] != last_segment_name | ||
| ): |
There was a problem hiding this comment.
Assuming that last_segment_name is never None this should simplify to the below.
Suggested change
| if ( | |
| fs.get("segment_name") is not None | |
| and fs["segment_name"] != last_segment_name | |
| ): | |
| if ( | |
| fs.get("segment_name") != last_segment_name | |
| ): |
There was a problem hiding this comment.
fs.get("segment_name") can be None
Comment on lines
+32
to
+38
| return ( | ||
| "| Environment | Enabled | Value | Last Updated (UTC) |\n" | ||
| "| :--- | :----- | :------ | :------ |\n" | ||
| f"| [Test Environment](https://example.com/project/{project_id}/" | ||
| f"environment/{environment_api_key}/features?feature={feature_id}&tab=value) " | ||
| f"| {feature_state_enabled} | {feature_state_value} | {feature_state_updated_at} |\n" | ||
| ) |
There was a problem hiding this comment.
Can you double check this? I don't think the data will line up in columns properly but maybe you already know this.
There was a problem hiding this comment.
Double-check is ok, I attached an image:
Comment on lines
41
to
48
| def expected_segment_comment_body( | ||
| project_id, | ||
| environment_api_key, | ||
| feature_id, | ||
| segment_override_updated_at, | ||
| segment_override_enabled, | ||
| segment_override_value, | ||
| ) -> str: |
Comment on lines
24
to
30
| def expected_default_body( | ||
| project_id, | ||
| environment_api_key, | ||
| feature_id, | ||
| feature_state_updated_at, | ||
| feature_state_enabled="❌ Disabled", | ||
| feature_state_value="`value`", |
novakzaballa
deleted the
fix/segment_overrides_get_the_correct_value_when_create_github_comment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
AFTER_SAVEhook within thefeaturemodel to create a GitHub comment when the feature is deleted (we useAFTER_SAVEbecause it's a soft delete).How did you test this code?