-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: environment click sizes #4104
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this and it works well 👍
Any reason why you preferred this option instead of removing the link to the environment from the audit log list, and adding a link to the environment from the individual audit log entry instead?
Other things I don't like about having a link to the environment in the list:
- Environments that were deleted will link to a 404
- We support filtering audit log by environment, and it's not unreasonable to expect that clicking on the environment name on an audit log row would perform the same filtering
- It's still possible to accidentally click on the environment name and not realise this is a different click target. It's reasonable to expect customers to never use audit logs except during a crisis/downtime situation, so I strongly prefer any alternatives with the least surprises/cognitive load here
Hmm yeah good point I think you're right, I think let's keep this for now (I think it also improves UI) and plan to migrate actions to the far right(like in the feature list) since with versioning we'll also have a link to the version |
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes