Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: environment click sizes #4104

Merged
merged 2 commits into from
Jun 5, 2024
Merged

fix: environment click sizes #4104

merged 2 commits into from
Jun 5, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jun 4, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Adjusts click area for environment column of audit log

Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 2:14pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 2:14pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 2:14pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Jun 4, 2024
@kyle-ssg kyle-ssg linked an issue Jun 4, 2024 that may be closed by this pull request
4 tasks
Copy link
Contributor

github-actions bot commented Jun 4, 2024

Uffizzi Preview deployment-52626 was deleted.

Copy link
Member

@rolodato rolodato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and it works well 👍

Any reason why you preferred this option instead of removing the link to the environment from the audit log list, and adding a link to the environment from the individual audit log entry instead?

Other things I don't like about having a link to the environment in the list:

  • Environments that were deleted will link to a 404
  • We support filtering audit log by environment, and it's not unreasonable to expect that clicking on the environment name on an audit log row would perform the same filtering
  • It's still possible to accidentally click on the environment name and not realise this is a different click target. It's reasonable to expect customers to never use audit logs except during a crisis/downtime situation, so I strongly prefer any alternatives with the least surprises/cognitive load here

@kyle-ssg
Copy link
Member Author

kyle-ssg commented Jun 5, 2024

Hmm yeah good point I think you're right, I think let's keep this for now (I think it also improves UI) and plan to migrate actions to the far right(like in the feature list) since with versioning we'll also have a link to the version

@kyle-ssg kyle-ssg added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit 9d1622f Jun 5, 2024
21 checks passed
@kyle-ssg kyle-ssg deleted the fix/environment-tag-styles branch June 5, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit log click target for environment too large
2 participants