Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Limit feature paging to 50 #4120

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jun 6, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Feature list paging was set to 200 which was unnecessary since filtering has been done on the BE for a while now. Large lists optimise themselves by painting only visible rows, this was inadvertently causing issues with the feature action button.

Before:

image

After:
image

How did you test this code?

  • View a project with over 50 feature flags (previously it would have been over 200)
  • Tested paging and filtering
  • Tested feature actions

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 9:45am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 9:45am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 9:45am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Jun 6, 2024
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Uffizzi Preview deployment-52706 was deleted.

@gagantrivedi gagantrivedi added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit c14c3a8 Jun 6, 2024
18 checks passed
@gagantrivedi gagantrivedi deleted the fix/feature_list_paging branch June 6, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants