fix(django-upgrade): upgrade django major version #4136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagantrivedi
added
improvement
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
gagantrivedi
changed the title
gagantrivedi
changed the title
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4136 +/- ##
==========================================
+ Coverage 96.92% 96.95% +0.02%
==========================================
Files 1178 1152 -26
Lines 39623 39650 +27
==========================================
+ Hits 38405 38442 +37
+ Misses 1218 1208 -10 ☔ View full report in Codecov by Sentry. |
gagantrivedi
changed the title
gagantrivedi
added
api
matthewelwell
changed the title
|
@gagantrivedi just a heads up that I've updated the title of this PR to mark it as breaking |
gagantrivedi
force-pushed
the
feat/upgrade-django
branch
from
caffa2b to
56b5148
Compare
github-actions
bot
removed
the
dependencies
gagantrivedi
changed the title
gagantrivedi
changed the title
|
|
|
|
|
|
|
|
|
|
gagantrivedi
changed the title
gagantrivedi
changed the title
update pyproject.toml bump pytest-django update test remove default_app_config bump pytest-xdist rbac test fixes remove default_app_config cover fixes
gagantrivedi
force-pushed
the
feat/upgrade-django
branch
from
4fedc0a to
0f1d539
Compare
| ): | ||
| # Given | ||
| if ( | ||
| settings.IS_RBAC_INSTALLED and not is_admin_master_api_key_client |
There was a problem hiding this comment.
This feels slightly odd to me:
- I'd rather not have to use another parametrized argument for the boolean if we can avoid it (although I have looked into it myself and can't see any obvious options).
- If we do need to use the extra argument, why not invert it and use
is_admin_clientrather thanis_admin_master_api_key_client?
Either way, it'd be good to add a comment as to why we expect the extra query in this scenario.
Comment on lines
2594
to
2656
| if settings.IS_RBAC_INSTALLED: # pragma: no cover | ||
| num_queries += 1 |
There was a problem hiding this comment.
I guess what Gagan is trying to achieve here is a generic solution that works for both (one which includes all the private packages) and one which doesn't.
I guess with @khvn26 's approach, we could add a pytest.mark.skip perhaps?
gagantrivedi
force-pushed
the
feat/upgrade-django
branch
from
ff6f162 to
ecc95d1
Compare
gagantrivedi
added
api
gagantrivedi
force-pushed
the
feat/upgrade-django
branch
2 times, most recently
from
758fc94 to
4a3e2ce
Compare
gagantrivedi
added
api
matthewelwell
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Looks good to me, but keen to get @khvn26 's thoughts on the solution to the main discussion thread.
khvn26
approved these changes
Aug 27, 2024
gagantrivedi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
BREAKING CHANGE: Upgrade django major version
How did you test this code?
Updates tests