Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stale connections after task processor errors #4179

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Jun 18, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This fixes a problem surfaced in one of the on-prem environments when task processor wouldn't recover during database failover.

How did you test this code?

Manually in the on-prem environment where the problem was reproduced.

Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 7:08pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 7:08pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 7:08pm

@github-actions github-actions bot added the api Issue related to the REST API label Jun 18, 2024
@khvn26 khvn26 changed the base branch from main to feat/reusable-private-cloud-build June 18, 2024 12:18
@github-actions github-actions bot added the fix label Jun 18, 2024
@khvn26 khvn26 force-pushed the fix/stale-connections-after-task-processor-errors branch from 57587ab to 2a25357 Compare June 18, 2024 12:18
@github-actions github-actions bot added fix front-end Issue related to the React Front End Dashboard docs Documentation updates and removed fix labels Jun 18, 2024
Copy link
Contributor

github-actions bot commented Jun 18, 2024

Uffizzi Preview deployment-53151 was deleted.

@github-actions github-actions bot added fix and removed fix docs Documentation updates labels Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (b7c4f5f) to head (58746e0).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4179      +/-   ##
==========================================
- Coverage   96.50%   96.50%   -0.01%     
==========================================
  Files        1177     1177              
  Lines       38217    38215       -2     
==========================================
- Hits        36883    36881       -2     
  Misses       1334     1334              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khvn26 khvn26 force-pushed the feat/reusable-private-cloud-build branch from e509306 to d2e156e Compare June 18, 2024 12:45
@khvn26 khvn26 force-pushed the fix/stale-connections-after-task-processor-errors branch from 7ae7506 to 3baedc4 Compare June 18, 2024 12:49
@github-actions github-actions bot added fix and removed fix labels Jun 18, 2024
@khvn26 khvn26 force-pushed the feat/reusable-private-cloud-build branch from d2e156e to ec01d41 Compare June 18, 2024 13:35
@khvn26 khvn26 force-pushed the fix/stale-connections-after-task-processor-errors branch from 3baedc4 to 1f1814d Compare June 18, 2024 19:05
@github-actions github-actions bot added the docs Documentation updates label Jun 18, 2024
@khvn26 khvn26 changed the base branch from feat/reusable-private-cloud-build to main June 18, 2024 19:06
@khvn26 khvn26 force-pushed the fix/stale-connections-after-task-processor-errors branch from 1f1814d to 58746e0 Compare June 18, 2024 19:07
@github-actions github-actions bot added fix and removed fix docs Documentation updates labels Jun 18, 2024
@khvn26 khvn26 requested a review from matthewelwell June 18, 2024 19:09
@matthewelwell matthewelwell added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit 17782bd Jun 18, 2024
25 checks passed
@matthewelwell matthewelwell deleted the fix/stale-connections-after-task-processor-errors branch June 18, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants