-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Stale connections after task processor errors #4179
Merged
matthewelwell
merged 2 commits into
main
from
fix/stale-connections-after-task-processor-errors
Jun 18, 2024
Merged
fix: Stale connections after task processor errors #4179
matthewelwell
merged 2 commits into
main
from
fix/stale-connections-after-task-processor-errors
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
khvn26
force-pushed
the
fix/stale-connections-after-task-processor-errors
branch
from
June 18, 2024 12:18
57587ab
to
2a25357
Compare
github-actions
bot
added
fix
front-end
Issue related to the React Front End Dashboard
docs
Documentation updates
and removed
fix
labels
Jun 18, 2024
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4179 +/- ##
==========================================
- Coverage 96.50% 96.50% -0.01%
==========================================
Files 1177 1177
Lines 38217 38215 -2
==========================================
- Hits 36883 36881 -2
Misses 1334 1334 ☔ View full report in Codecov by Sentry. |
khvn26
force-pushed
the
feat/reusable-private-cloud-build
branch
from
June 18, 2024 12:45
e509306
to
d2e156e
Compare
khvn26
force-pushed
the
fix/stale-connections-after-task-processor-errors
branch
from
June 18, 2024 12:49
7ae7506
to
3baedc4
Compare
khvn26
force-pushed
the
feat/reusable-private-cloud-build
branch
from
June 18, 2024 13:35
d2e156e
to
ec01d41
Compare
khvn26
force-pushed
the
fix/stale-connections-after-task-processor-errors
branch
from
June 18, 2024 19:05
3baedc4
to
1f1814d
Compare
khvn26
force-pushed
the
fix/stale-connections-after-task-processor-errors
branch
from
June 18, 2024 19:07
1f1814d
to
58746e0
Compare
matthewelwell
approved these changes
Jun 18, 2024
matthewelwell
deleted the
fix/stale-connections-after-task-processor-errors
branch
June 18, 2024 20:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
This fixes a problem surfaced in one of the on-prem environments when task processor wouldn't recover during database failover.
How did you test this code?
Manually in the on-prem environment where the problem was reproduced.