fix: versioning webhooks and update test to correctly test end to end #4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4221 +/- ##
=======================================
Coverage 96.57% 96.57%
=======================================
Files 1190 1190
Lines 38747 38754 +7
=======================================
+ Hits 37419 37426 +7
Misses 1328 1328 ☔ View full report in Codecov by Sentry. |
gagantrivedi
approved these changes
Jun 25, 2024
matthewelwell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Fixes an issue with the webhooks for environment feature versions that was supposed to be fixed in #4187 but, because the test was just mocking the call to
call_environment_webhooks, that was not the case. This PR fixes it properly and updates the test to run the full end to end webhook flow.How did you test this code?
Updated existing test.