Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Enable Docker builds and E2E for external PRs #4224

Merged
merged 3 commits into from
Jun 25, 2024
Merged

fix(ci): Enable Docker builds and E2E for external PRs #4224

merged 3 commits into from
Jun 25, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Jun 25, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This does a few things:

  • For PRs opened by external contributors, skip pushing built images to Github Container registry. Push to an ephemeral registry instead.
  • For PRs opened by external contributors, skip building the Private cloud image altogether.
  • Remove Private cloud E2E for PRs for now. When we have Private cloud-specific E2E scenarios, we'll be able to run them by adding a E2E job depending on private-cloud build.
  • When running E2E, pull ephemeral Depot images if a Depot build ID was provided.
  • When running E2E, display API container logs on failure as part of the Makefile target.
  • Add secrets: inherit for the release/merge to main E2E run so errors are reported to Slack correctly.

How did you test this code?

Tested the Makefile change locally.
The rest of the changes will be tested in CI.

@khvn26 khvn26 requested a review from a team as a code owner June 25, 2024 11:55
@khvn26 khvn26 requested review from kyle-ssg and removed request for a team June 25, 2024 11:55
@vercel Vercel
Copy link

vercel bot commented Jun 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2024 0:31am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2024 0:31am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2024 0:31am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Jun 25, 2024
@khvn26 khvn26 requested a review from matthewelwell June 25, 2024 11:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 25, 2024 •
edited
Loading

Uffizzi Preview deployment-53456 was deleted.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jun 25, 2024
@matthewelwell
Copy link
Contributor

Remove Private cloud E2E for PRs for now. When we have Private cloud-specific E2E scenarios, we'll be able to run them by adding a E2E job depending on private-cloud build.

So I guess we'll still run them against the private-cloud image on a merge to main?

matthewelwell
matthewelwell approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor comment (above)

@khvn26
Copy link
Member Author

khvn26 commented Jun 25, 2024 •
edited
Loading

So I guess we'll still run them against the private-cloud image on a merge to main?

Yes we will.

@codecov Codecov
Copy link

codecov bot commented Jun 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.57%. Comparing base (47eb149) to head (182cef2).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4224   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files        1190     1190           
  Lines       38754    38754           
=======================================
  Hits        37426    37426           
  Misses       1328     1328

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khvn26 khvn26 force-pushed the fix/docker-build-external-contributors branch from b25faf9 to 44e6924 Compare June 25, 2024 12:08
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jun 25, 2024
@khvn26 khvn26 changed the title feat(ci): Enable Docker builds and E2E for external PRs fix(ci): Enable Docker builds and E2E for external PRs Jun 25, 2024
@github-actions github-actions bot added fix and removed feature New feature or request labels Jun 25, 2024
@khvn26 khvn26 added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit fe7cc53 Jun 25, 2024
28 checks passed
@khvn26 khvn26 deleted the fix/docker-build-external-contributors branch June 25, 2024 12:56
@dabeeeenster dabeeeenster mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

@kyle-ssg kyle-ssg Awaiting requested review from kyle-ssg kyle-ssg is a code owner automatically assigned from Flagsmith/flagsmith-front-end

Assignees
No one assigned
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khvn26 @matthewelwell