Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update API usage notifications thresholds #4255

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

zachaysan
Copy link
Contributor

@zachaysan zachaysan commented Jun 26, 2024

Changes

Fixes #4231

Update API usage notifications thresholds for sending notifications to Flagsmith staff and admins.

How did you test this code?

Relied on existing tests for the underlying logic.

@zachaysan zachaysan requested a review from a team as a code owner June 26, 2024 18:06
@zachaysan zachaysan requested review from gagantrivedi and removed request for a team June 26, 2024 18:06
Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jun 26, 2024 6:12pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jun 26, 2024 6:12pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jun 26, 2024 6:12pm

@zachaysan zachaysan requested review from matthewelwell and removed request for gagantrivedi June 26, 2024 18:06
@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Jun 26, 2024
Copy link
Contributor

github-actions bot commented Jun 26, 2024

Uffizzi Preview deployment-53545 was deleted.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.57%. Comparing base (ca2b13b) to head (739a2bd).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4255   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files        1190     1191    +1     
  Lines       38804    38809    +5     
=======================================
+ Hits        37476    37481    +5     
  Misses       1328     1328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachaysan zachaysan added this pull request to the merge queue Jun 27, 2024
Merged via the queue into main with commit 5162687 Jun 27, 2024
28 checks passed
@zachaysan zachaysan deleted the feat/upgrade_notification_values branch June 27, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Max value for percent usage on APIUsageNotification set higher
2 participants