fix: Set early return when influxdb range is empty #4274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
|
Uffizzi Preview |
gagantrivedi
approved these changes
Jul 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4274 +/- ##
=======================================
Coverage 96.60% 96.60%
=======================================
Files 1195 1195
Lines 39099 39104 +5
=======================================
+ Hits 37773 37778 +5
Misses 1326 1326 ☔ View full report in Codecov by Sentry. |
matthewelwell
deleted the
fix/set_early_return_when_influxdb_range_is_empty
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The API usage related refactor cropped up a new issue when the set range is effectively empty. Before this change users were getting the right results due to a broad try / except, but we were spamming Sentry with pointless logged errors. This fix early returns to avoid the empty set causing an issue.
How did you test this code?
Wrote a simple unit test.