Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Highlight selected options #4311

Merged
merged 1 commit into from
Jul 9, 2024
Merged

feat: Highlight selected options #4311

merged 1 commit into from
Jul 9, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jul 9, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Styles selected options

image

How did you test this code?

  • Viewed selected environment

@kyle-ssg kyle-ssg requested a review from a team as a code owner July 9, 2024 08:32
@kyle-ssg kyle-ssg requested review from novakzaballa and removed request for a team July 9, 2024 08:32
@vercel Vercel
Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 8:32am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 8:32am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jul 9, 2024 8:32am

@kyle-ssg kyle-ssg requested a review from rolodato July 9, 2024 08:32
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jul 9, 2024
@kyle-ssg kyle-ssg linked an issue Jul 9, 2024 that may be closed by this pull request
Highlight current environment in selector dropdown #4283
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

flagsmith-private-cloud image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4311 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

flagsmith image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith:pr-4311 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

flagsmith-frontend image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-frontend:pr-4311 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

flagsmith-api image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api:pr-4311 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

flagsmith-e2e image build finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4311 Finished ✅ Skipped

@kyle-ssg kyle-ssg changed the title style: Selected options feat: Selected options Jul 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

Uffizzi Preview deployment-53981 was deleted.

rolodato
rolodato approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@rolodato rolodato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'd just change the title of the PR to something more descriptive. For example, "Highlight currently selected environment more clearly"

@kyle-ssg kyle-ssg added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit d32a320 Jul 9, 2024
28 checks passed
@kyle-ssg kyle-ssg deleted the style/selected-options branch July 9, 2024 12:40
@kyle-ssg kyle-ssg changed the title feat: Selected options feat: Highlight selected options Jul 9, 2024
@kyle-ssg
Copy link
Member Author

kyle-ssg commented Jul 9, 2024

It affects all selects, not just the environment dropdown, adjusted title.

@flagsmithdev flagsmithdev mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolodato rolodato rolodato approved these changes

@novakzaballa novakzaballa Awaiting requested review from novakzaballa novakzaballa is a code owner automatically assigned from Flagsmith/flagsmith-front-end

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Highlight current environment in selector dropdown
2 participants
@kyle-ssg @rolodato