Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: frontend fails to load when announcement flag isn't set #4329

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fix: frontend fails to load when announcement flag isn't set #4329

merged 1 commit into from
Jul 12, 2024

Conversation

matthewelwell
Copy link
Contributor

Changes

Fixes an error which prevents the FE from loading when the announcement flag isn't set.

How did you test this code?

Ran the FE locally pointing to a flagsmith on flagsmith environment that doesn't have the announcement flag set.

@matthewelwell matthewelwell requested a review from a team as a code owner July 12, 2024 12:59
@matthewelwell matthewelwell requested review from kyle-ssg and removed request for a team July 12, 2024 12:59
@vercel Vercel
Copy link

vercel bot commented Jul 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 1:43pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 1:43pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 12, 2024 1:43pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Jul 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 12, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4329 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4329 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4329 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-4329 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4329 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4329 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4329 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 12, 2024 •
edited
Loading

Uffizzi Preview deployment-54129 was deleted.

@matthewelwell matthewelwell force-pushed the fix/announcement-parsing-error branch from 3861704 to ba39595 Compare July 12, 2024 13:38
@github-actions github-actions bot added fix and removed fix labels Jul 12, 2024
@matthewelwell matthewelwell force-pushed the fix/announcement-parsing-error branch from ba39595 to 8c39c4d Compare July 12, 2024 13:41
@github-actions github-actions bot added fix and removed fix labels Jul 12, 2024
@matthewelwell matthewelwell requested a review from kyle-ssg July 12, 2024 13:49
@matthewelwell matthewelwell added this pull request to the merge queue Jul 12, 2024
Merged via the queue into main with commit c047233 Jul 12, 2024
29 checks passed
@matthewelwell matthewelwell deleted the fix/announcement-parsing-error branch July 12, 2024 13:54
@flagsmithdev flagsmithdev mentioned this pull request Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novakzaballa novakzaballa novakzaballa approved these changes

@kyle-ssg kyle-ssg Awaiting requested review from kyle-ssg

Assignees
No one assigned
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewelwell @kyle-ssg @novakzaballa