Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Incorrect package used for GPG #4355

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Jul 18, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This fixes gpg not being available to the SaaS Docker image build:

 > [saas-api 1/4] RUN --mount=type=secret,id=sse_pgp_pkey   apk add gnupg &&   gpg --import /run/secrets/sse_pgp_pkey &&   mv /root/.gnupg/ /app/ &&   chown -R nobody /app/.gnupg/:
#0 0.745 (1/1) Installing gnupg (2.2.41-r2)
#0 0.934 OK: 76 MiB in 32 packages
#0 0.976 /bin/sh: gpg: not found
------

https://github.com/Flagsmith/flagsmith/actions/runs/9990074115/job/27609995476

How did you test this code?

Ran docker build --target saas-api . locally.

Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jul 18, 2024 10:53am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Jul 18, 2024 10:53am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Jul 18, 2024 10:53am

@github-actions github-actions bot added the fix label Jul 18, 2024
Copy link
Contributor

github-actions bot commented Jul 18, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4355 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4355 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4355 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4355 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4355 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4355 Finished ✅ Results

@khvn26 khvn26 added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit aa2fd70 Jul 18, 2024
19 checks passed
@khvn26 khvn26 deleted the fix/incorrect-gpg-package branch July 18, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants