Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Styling alert for API usage banner #4360

Merged
merged 1 commit into from
Jul 18, 2024
Merged

fix: Styling alert for API usage banner #4360

merged 1 commit into from
Jul 18, 2024

Conversation

novakzaballa
Copy link
Contributor

@novakzaballa novakzaballa commented Jul 18, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Screenshot 2024-07-18 at 1 54 29 PM

How did you test this code?

  • Force display the api usage Banner

@novakzaballa novakzaballa added the bug Something isn't working label Jul 18, 2024
@novakzaballa novakzaballa requested a review from a team as a code owner July 18, 2024 17:55
@novakzaballa novakzaballa requested review from kyle-ssg and removed request for a team July 18, 2024 17:55
@vercel Vercel
Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 5:55pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 5:55pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jul 18, 2024 5:55pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Jul 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4360 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4360 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4360 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4360 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4360 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4360 Finished ✅ Results ✅

@novakzaballa novakzaballa linked an issue Jul 18, 2024 that may be closed by this pull request
Fix styling alert for API usage banner #4230
Closed
@novakzaballa novakzaballa requested a review from zachaysan July 18, 2024 17:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024 •
edited
Loading

Uffizzi Preview deployment-54370 was deleted.

@novakzaballa novakzaballa added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit 61cfdbf Jul 18, 2024
30 checks passed
@novakzaballa novakzaballa deleted the fix/styling-alert-for-api-usage-banner branch July 18, 2024 19:00
@flagsmithdev flagsmithdev mentioned this pull request Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachaysan zachaysan zachaysan approved these changes

@kyle-ssg kyle-ssg Awaiting requested review from kyle-ssg kyle-ssg is a code owner automatically assigned from Flagsmith/flagsmith-front-end

Assignees
No one assigned
Labels
bug Something isn't working fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix styling alert for API usage banner
2 participants
@novakzaballa @zachaysan