Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Delete scheduled change request #4437

Merged
merged 2 commits into from
Jul 31, 2024
Merged

fix: Delete scheduled change request #4437

merged 2 commits into from
Jul 31, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

image

Adds ability to delete a scheduled change request.

How did you test this code?

  • View a scheduled change, see delete button
  • View an unscheduled committed change, don't see the button

@kyle-ssg kyle-ssg requested a review from a team as a code owner July 31, 2024 13:54
@kyle-ssg kyle-ssg requested review from novakzaballa and removed request for a team July 31, 2024 13:54
@vercel Vercel
Copy link

vercel bot commented Jul 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 2:14pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 2:14pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2024 2:14pm

@kyle-ssg kyle-ssg requested review from rolodato and a team July 31, 2024 13:54
@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Jul 31, 2024
@kyle-ssg kyle-ssg linked an issue Jul 31, 2024 that may be closed by this pull request
No option to delete scheduled changes #4421
Closed
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 31, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4437 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4437 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4437 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4437 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4437 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4437 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 31, 2024 •
edited
Loading

Uffizzi Preview deployment-54856 was deleted.

@github-actions github-actions bot added fix and removed fix labels Jul 31, 2024
@kyle-ssg kyle-ssg added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit 233ce50 Jul 31, 2024
30 checks passed
@kyle-ssg kyle-ssg deleted the fix/delete-scheduled-change-request branch July 31, 2024 14:26
@flagsmithdev flagsmithdev mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolodato rolodato rolodato approved these changes

@novakzaballa novakzaballa Awaiting requested review from novakzaballa novakzaballa is a code owner automatically assigned from Flagsmith/flagsmith-front-end

Assignees
No one assigned
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No option to delete scheduled changes
2 participants
@kyle-ssg @rolodato