Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show correct SAML Frontend URL on edit #4462

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

matthewelwell
Copy link
Contributor

Changes

Ensures that the current stored Frontend URL is shown when editing, instead of using the current URL.

Also includes a bonus fix for a typo.

How did you test this code?

Ran the FE against production and tested create / edit.

@matthewelwell matthewelwell requested a review from a team as a code owner August 7, 2024 16:42
@matthewelwell matthewelwell requested review from kyle-ssg and removed request for a team August 7, 2024 16:42
Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 4:42pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 4:42pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Aug 7, 2024 4:42pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Aug 7, 2024
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4462 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4462 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4462 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4462 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4462 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4462 Finished ✅ Results

@kyle-ssg
Copy link
Member

kyle-ssg commented Aug 7, 2024

Let's convet this to done

@matthewelwell matthewelwell added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit 13ad7ef Aug 7, 2024
31 checks passed
@matthewelwell matthewelwell deleted the fix/saml-configuration-always-uses-current-url branch August 7, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants